Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the rotate-screen image on iOS Safari for maze levels #32240

Merged
merged 3 commits into from Dec 3, 2019

Conversation

jmkulwik
Copy link
Contributor

@jmkulwik jmkulwik commented Dec 3, 2019

Description

Previously, going to studio.code.org/hoc/1 and then studio.code.org/hoc/3 on an iOS device would cause the rotate image to display partly offscreen.
image

This applies the fix from a the same issue in the oceans HOC tutorial #32206

image

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

apps/src/StudioApp.js Outdated Show resolved Hide resolved
@jmkulwik jmkulwik merged commit 9d55977 into staging Dec 3, 2019
@jmkulwik jmkulwik deleted the maze-fix-rotation-image branch December 3, 2019 20:06
@breville
Copy link
Member

I just noticed that this causes both fixViewportForSmallScreens_ and fixViewportForSpecificWidthForSmallScreens_ to be called, with the latter having the final word. Ideally, only one of these should be called. For example, in the case of /s/oceans, only the latter is called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants