Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate FreeResponse fields #33970

Merged
merged 2 commits into from Apr 1, 2020
Merged

Translate FreeResponse fields #33970

merged 2 commits into from Apr 1, 2020

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Apr 1, 2020

Begin syncing translations for the "title" and "placeholder" fields.

Work to use those translations will come in a later PR.

You can see the full diff of all expected new strings here: https://gist.github.com/Hamms/865694580d1af0261b6b3dc3ff367ae5

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@Hamms Hamms requested a review from a team as a code owner April 1, 2020 17:18
bethanyaconnor
bethanyaconnor approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@bethanyaconnor bethanyaconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we never use a level-specific placeholder then? I don't see one in the expected diff

@Hamms
Copy link
Contributor Author

Hamms commented Apr 1, 2020

We do, but only in CSP

@Hamms Hamms mentioned this pull request Apr 1, 2020
Merged
7 tasks
@Hamms Hamms merged commit 2944f89 into staging Apr 1, 2020
@Hamms Hamms deleted the translate-FreeResponse-fields branch April 1, 2020 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bethanyaconnor bethanyaconnor bethanyaconnor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hamms @bethanyaconnor