Use FreeResponse translations #33974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daynew
approved these changes
Apr 3, 2020
| @@ -48,8 +48,7 @@ | |||
| ReactDOM.render(React.createElement(dashboard.Attachments, {showUnderageWarning: !appOptions.is13Plus, readonly: #{!!@view_options.readonly_workspace}}), document.querySelector('#free-response-upload')); | |||
|
|
|||
| - height = level.height || '80' | |||
| -# FND-984 placeholder needs to be localized level property. | |||
| - placeholder = level.placeholder || I18n.t('free_response.placeholder') | |||
There was a problem hiding this comment.
I think we still want the || I18n.t('free_response.placeholder') so the default text is still there. Most levels don't define the 'placeholder' property.
dashboard/config/locales/en.yml
Outdated
| @@ -719,8 +719,6 @@ en: | |||
| help_support: "Help and support" | |||
| documentation: "Documentation" | |||
| tutorials: "Tutorials" | |||
| free_response: | |||
| placeholder: "Enter your answer here" | |||
There was a problem hiding this comment.
Related to comment above. I'm not sure we want to remove this.
…placeholder values.
daynew
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use translations of FreeResponse fields (added in #33970) in the view. Also remove the placeholder placeholder we added to hold us over until now.
Links
Testing story
Added a test translation file to
dashboard/config/locales/free_responses.es-MX.yml:Then checked
http://localhost-studio.code.org:3000/s/csp1-2018/stage/1/puzzle/3/lang/es-mx:Reviewer Checklist: