Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create parent_levels_child_levels table #34618

Merged
merged 2 commits into from May 6, 2020

Conversation

davidsbailey
Copy link
Member

@davidsbailey davidsbailey commented May 5, 2020

See freshly updated Levels within Levels proposal for background. This is the first step toward implementing PLAT-95.

Testing story

Tests will be added in #34584

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@davidsbailey davidsbailey changed the title create parent-levels-child-levels table create parent_levels_child_levels table May 5, 2020
@davidsbailey davidsbailey marked this pull request as ready for review May 5, 2020 14:22
@uponthesun
Copy link

Where did we land on the kind column? I couldn't tell from discussion in #34586.

@davidsbailey
Copy link
Member Author

Where did we land on the kind column? I couldn't tell from discussion in #34586.

I can hold off a bit longer for that decision, but if that discussion spills into tomorrow then I'd like to proceed with this change and the decision on the kind column can come later.

@davidsbailey
Copy link
Member Author

It sounds like we have consensus on using the kind column. I'll add it in a next PR.

@davidsbailey davidsbailey merged commit e15fcb4 into staging May 6, 2020
@davidsbailey davidsbailey deleted the parent-levels-child-levels-migration branch November 24, 2020 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants