add kind column to parent_levels_child_levels table #34649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
changed the title
davidsbailey
force-pushed
the
child-level-kind-migration
branch
from
76e808c
to
eebf8e5
Compare
7 tasks
uponthesun
approved these changes
May 6, 2020
| @@ -0,0 +1,5 @@ | |||
| class AddKindToParentLevelsChildLevels < ActiveRecord::Migration[5.0] | |||
| def change | |||
| add_column :parent_levels_child_levels, :kind, :string, null: false, default: 'sublevel' | |||
There was a problem hiding this comment.
Is default only used because the existing table needs to be backfilled? Just checking for my understanding.
There was a problem hiding this comment.
default is so that if you do not specify a value, you'll get a sublevel, rather than a validation error, in the next PR #34650 . the unit tests there attempt to illustrate this
There was a problem hiding this comment.
I think it's slightly better to require a value, but not enough to ask you to change anything. Would be an interesting topic to discuss for next time this comes up, if you feel differently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on to #34618 (comment)