Adding languages other than English to the text to speech block in app lab and game lab #35077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmkulwik
reviewed
Jun 16, 2020
|
I was curious what the experiment flag was, so I went and looked it up. Here it is in case anyone else is curious: |
jmkulwik
reviewed
Jun 17, 2020
jmkulwik
reviewed
Jun 17, 2020
jmkulwik
reviewed
Jun 17, 2020
| @@ -32,6 +33,19 @@ const dropletConfig = { | |||
| 0: () => getAssetDropdown('audio') | |||
| }, | |||
| assetTooltip: {0: chooseAsset.bind(null, 'audio')} | |||
| }, | |||
| playSpeech: { | |||
There was a problem hiding this comment.
Do we need to hide this block behind an experiment?
There was a problem hiding this comment.
it's behind an experiment in applab and gamelab and it needs to be added to a lab's specific dropletConfig to show up.
jmkulwik
reviewed
Jun 17, 2020
| @@ -32,6 +32,10 @@ def self.table | |||
| table.select(:unique_language_s, :locale_s).where("locale_s = '#{locale}'").first[:unique_language_s] | |||
| end | |||
|
|
|||
| cached def self.get_native_name_by_locale(locale) | |||
| table.select(:native_name_s, :locale_s).where("locale_s = '#{locale}'").to_a | |||
There was a problem hiding this comment.
does this method error if we pass in an invalid locale?
There was a problem hiding this comment.
no, it just returns empty.
Comment on lines
489
to
490
| p 'hello world' | ||
| p Languages.get_native_name_by_locale('fake language') |
There was a problem hiding this comment.
nit: remove stray logging (but thank you for testing this! 😄 )
maddiedierker
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for languages other than English for the text to speech block. The languages that are offered are the intersection of languages that have both male and female voices offered by Azure and are supported by Code.org. The default is still the female English (US) voice.
Here's the full list: 2 dialects of English (US and UK), 2 dialects of Spanish (Latin America and Spain), French, German, Hindi, Italian, Japanese, Portuguese, Russian, and 2 dialects of Chinese (Simplified and Traditional).
This is currently behind the experiment text-to-speech-block, see here
Future work
In the future, we will add profanity filtering and a character limit for the block.
Links
Testing story
I think the tests in the earlier PR are sufficient but let me know if there's something else we should be testing.
Reviewer Checklist: