Text to speech block in app lab and game lab #34919
Conversation
JillianK
force-pushed
the
applab-text-to-speech-block
branch
from
0840dfe
to
a7934f0
Compare
JillianK
force-pushed
the
applab-text-to-speech-block
branch
from
a7934f0
to
ed4ba6f
Compare
| Sound.prototype.getPlayableBytes = function() { | ||
| try { | ||
| if (!window.Audio) { | ||
| return false; |
There was a problem hiding this comment.
why false not undefined or null?
There was a problem hiding this comment.
I was following the style of getPlayableFile (the function above). Should I switch to undefined?
|
IMO: Since we only support English, we shouldn't offer the option to change languages. That feels like a broken promise to me. We should add that option when we add more languages. |
|
When I run this locally (Windows 10, Chrome), using the default block EDIT: Wait a minute!! I wasn't auto-rebuilding after changes. Let me check that again. |
If you want to run locally, you need keys from me |
|
almost forgot -- before you merge this, let's add the API keys to each environment together. we can do this after today's standup |
Added a text to speech block to app lab and game lab that takes in text, output voice gender, and language (currently only english is supported). The block is under UI in app lab and World in game lab. It defaults to female and en-us if given invalid input.
In app lab:
In game lab:
as a block:
Future work
At some point, we need to go back and add support for more languages.
Links
Testing story
There's a test for the arguments of play speech which I think should be sufficient (since we aren't pausing or stopping speech) but let me know if there's something else we need.
Reviewer Checklist: