Levelbuilder Clean Up: Remove all edit file #35162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
approved these changes
Jun 8, 2020
Comment on lines
+1
to
+7
| /* global levelbuilder */ | ||
| import $ from 'jquery'; | ||
|
|
||
| $(document).ready(initPage); | ||
|
|
||
| function initPage() { | ||
| levelbuilder.jsonEditor('#callout_editor', { |
There was a problem hiding this comment.
this is fine for now, but we should think about getting rid of the pattern of defining globals in levelbuilder.js in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for the final clean up the files for editing levels this moves things out of the all editor so they can easily be moved to other files.