-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Levelbuilder Clean Up: Remove all edit file #35162
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d31e254
Move callouts out of all editor
dmcavoy ed72517
move sharing out of all editor
dmcavoy ababac0
Move video out of all editor
dmcavoy e843334
Move bubble choice sublevel out of all editor
dmcavoy 62521f8
Remove unused adding multi reference link since now text area
dmcavoy 502267c
Move preload assets and special level types out of all editor. Delete…
dmcavoy 8ac1686
Merge branch 'karel-edit' into remove-all-file
dmcavoy e640184
Merge branch 'staging' into remove-all-file
dmcavoy File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
34 changes: 34 additions & 0 deletions
34
apps/src/sites/studio/pages/levels/editors/fields/_callouts.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
/* global levelbuilder */ | ||
import $ from 'jquery'; | ||
|
||
$(document).ready(initPage); | ||
|
||
function initPage() { | ||
levelbuilder.jsonEditor('#callout_editor', { | ||
json_textarea: '#level_callout_json', | ||
add_button: '#add_callout', | ||
remove_button: '.remove_callout', | ||
value_space: '.callout_space', | ||
template: '.json_template', | ||
form_container: '#all_callouts_editor', | ||
wrapper: '.json_editor', | ||
model: { | ||
localization_key: '', | ||
callout_text: '', | ||
element_id: '', | ||
on: '', | ||
qtip_config: { | ||
codeStudio: { | ||
canReappear: false, | ||
dropletPaletteCategory: '' | ||
}, | ||
style: {classes: ''}, | ||
position: { | ||
my: '', | ||
at: '', | ||
adjust: {x: 0, y: 0} | ||
} | ||
} | ||
} | ||
}); | ||
} |
12 changes: 12 additions & 0 deletions
12
apps/src/sites/studio/pages/levels/editors/fields/_preload_assets.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import $ from 'jquery'; | ||
|
||
$(document).ready(initPage); | ||
|
||
function initPage() { | ||
$('#plusPreloadAssetList').on('click', () => { | ||
$('#plusPreloadAssetList') | ||
.prev() | ||
.clone() | ||
.insertBefore('#plusPreloadAssetList'); | ||
}); | ||
} |
12 changes: 12 additions & 0 deletions
12
apps/src/sites/studio/pages/levels/editors/fields/_special_level_types.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import $ from 'jquery'; | ||
|
||
$(document).ready(initPage); | ||
|
||
function initPage() { | ||
$('#plusAnswerContainedLevel').on('click', () => { | ||
$('#plusAnswerContainedLevel') | ||
.prev() | ||
.clone() | ||
.insertBefore('#plusAnswerContainedLevel'); | ||
}); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
3 changes: 3 additions & 0 deletions
3
dashboard/app/views/levels/editors/fields/_callouts.html.haml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
dashboard/app/views/levels/editors/fields/_preload_assets.html.haml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
dashboard/app/views/levels/editors/fields/_special_level_types.html.haml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is fine for now, but we should think about getting rid of the pattern of defining globals in levelbuilder.js in the future.