Display informational warning when code is edited while its running #35351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmkulwik
reviewed
Jun 17, 2020
jmkulwik
reviewed
Jun 17, 2020
jmkulwik
reviewed
Jun 17, 2020
jmkulwik
reviewed
Jun 17, 2020
| this.editDuringRunAlert = undefined; | ||
| } | ||
| } else { | ||
| this.executingCode = this.getCode().trim(); |
There was a problem hiding this comment.
The change handlers are also run when you toggle between code and block mode in droplet so we need the code when the user clicked run to compare against later to see if there was an actual change.
jmkulwik
reviewed
Jun 17, 2020
jmkulwik
reviewed
Jun 17, 2020
Hamms
reviewed
Jun 17, 2020
JillianK
force-pushed
the
informational-warning
branch
from
fcd7809
to
344e27f
Compare
7 tasks
7 tasks
Created a WorkspaceAlert wrapper for the alert component.
jmkulwik
reviewed
Jun 26, 2020
jmkulwik
reviewed
Jun 26, 2020
jmkulwik
reviewed
Jun 26, 2020
jmkulwik
reviewed
Jun 26, 2020
jmkulwik
reviewed
Jun 26, 2020
jmkulwik
reviewed
Jun 26, 2020
jmkulwik
reviewed
Jun 26, 2020
jmkulwik
reviewed
Jun 26, 2020
jmkulwik
reviewed
Jun 26, 2020
jmkulwik
reviewed
Jun 26, 2020
apps/src/StudioApp.js
Outdated
| var container = $('<div/>'); | ||
| parent.append(container); | ||
| ReactDOM.render( | ||
| <WorkspaceAlert |
There was a problem hiding this comment.
please do continue to avoid using JSX syntax inside non-JSX files
There was a problem hiding this comment.
@Hamms - what's the preferred way to write this?
There was a problem hiding this comment.
I just switched it to use createElement like you suggested earlier, let me know if this wasn't what you meant
There was a problem hiding this comment.
oh, sorry I missed this. Yep, createElement is preferred! Thanks
This was referenced Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This displays a warning at the bottom of the workspace if someone makes changes in the workspace while the code is running. This warning will only show up once during a run and go away if they close it or if they click reset (for example, if you run, edit, close the warning, and then edit again you won't get the warning again during this run but it will show up again if you reset, run, and then edit).
Game Lab:
App Lab on mobile:
Dance Party:
Sprite Lab on mobile:
Craft:
Craft on mobile:
Links
Testing story
Reviewer Checklist: