Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the step button when the user edits running code #35393

Merged
merged 3 commits into from Jun 30, 2020

Conversation

JillianK
Copy link
Contributor

@JillianK JillianK commented Jun 18, 2020

Disables the "step" buttons (step into, step out of, step over) in AppLab and GameLab if the user makes an edit to their code while it's running.

AppLab:
Screen Shot 2020-06-18 at 1 26 11 PM

GameLab
Screen Shot 2020-06-18 at 1 26 59 PM

Message for disabled buttons that shows up on hover:
Screen Shot 2020-06-24 at 1 29 02 PM

Background

Note that this is a branch off of this PR to reuse logic that recognizes code changes while code is running.

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@jmkulwik
Copy link
Contributor

Playing through a level, it feels unclear to me why stepping is disabled sometimes and enabled other times. In addition to the popup at the bottom of the coding workspace, we need something in the debugger space. I'd suggest adding a title or a tooltip to the buttons and changing the debugger header to the lighter purple that's being used in the workspace. It might be nice to take it a step further and add an overlay to the debugger space and gray out the debugger background.

Copy link
Contributor

@jmkulwik jmkulwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!! 🎉 The message over the buttons is super helpful

Base automatically changed from informational-warning to staging June 29, 2020 14:52
@JillianK JillianK merged commit ade727e into staging Jun 30, 2020
@JillianK JillianK deleted the disable-step-on-edit branch June 30, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants