Revert "Revert "Maker: Enable micro:bit toolkit in App Lab"" #36520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breville
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: These are amendments to this original PR: #36288
I merged that^ PR and then Brendan and I chatted a bit about this comment: #36288 (comment) and I decided I wanted to revert it and test it more thoroughly. I ended up exploring this code more and made two small changes.
The first change is to make sure that both the CP and MB blocks are grayed out when the maker toolkit is disabled. Previously, only the CP blocks were grayed out.
The second change is to remove a reference to the
experiments.isEnabled(MICROBIT).cc: @breville