Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spritelab set background as block #36579

Merged
merged 25 commits into from Nov 4, 2020
Merged

Conversation

JillianK
Copy link
Contributor

@JillianK JillianK commented Sep 2, 2020

This adds a new set background as block to replace the existing set background block. In this version, the dropdown has the images corresponding to the backgrounds and you can add more from the animation library. It also changes backgrounds to be treated like animations, similar to gamelab. This should not change the behavior for animations in gamelab.
Sep-02-2020 15-15-38

This PR is set up for testing purposes. Before merging we need to:

  • Merge this PR
  • remove the logic for the custom spritelab manifest along with the custom spritelab manifest (customSpritelabCostumeLibrary.json)
  • Update the actual spritelab manifest in s3 to contain backgrounds
  • Update default sprites to have backgrounds in them instead of the fake elements added for testing purposes (the technical changes for this are in this PR)

Links

Testing story

There are tests for displaying the correct list items when we're looking for animations in spritelab, looking for animations in gamelab, and looking for backgrounds.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@JillianK JillianK requested a review from a team September 2, 2020 23:18
Base automatically changed from jk-background-logic to staging September 25, 2020 16:55
Copy link
Contributor

@maddiedierker maddiedierker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉

apps/src/p5lab/P5LabView.jsx Outdated Show resolved Hide resolved
@JillianK JillianK requested a review from a team as a code owner November 3, 2020 21:52
@JillianK JillianK merged commit e3caa22 into staging Nov 4, 2020
@JillianK JillianK deleted the jk-new-background-block-spritelab branch November 4, 2020 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants