New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spritelab set background as block #36579
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
…t-org into jk-new-background-block-spritelab
…t-org into jk-new-background-block-spritelab
…t-org into jk-new-background-block-spritelab
…t-org into jk-new-background-block-spritelab
…t-org into jk-new-background-block-spritelab
ajpal
reviewed
Sep 16, 2020
ajpal
reviewed
Sep 16, 2020
…t-org into jk-new-background-block-spritelab
…t-org into jk-new-background-block-spritelab
…t-org into jk-new-background-block-spritelab
…t-org into jk-new-background-block-spritelab
…t-org into jk-new-background-block-spritelab
…t-org into jk-new-background-block-spritelab
…t-org into jk-new-background-block-spritelab
…t-org into jk-new-background-block-spritelab
maddiedierker
approved these changes
Nov 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 🎉 🎉
…k-new-background-block-spritelab
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new set background as block to replace the existing set background block. In this version, the dropdown has the images corresponding to the backgrounds and you can add more from the animation library. It also changes backgrounds to be treated like animations, similar to gamelab. This should not change the behavior for animations in gamelab.
This PR is set up for testing purposes. Before merging we need to:
Links
Testing story
There are tests for displaying the correct list items when we're looking for animations in spritelab, looking for animations in gamelab, and looking for backgrounds.
Reviewer Checklist: