Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spritelab set background as block backwards compatibility #37744

Merged
merged 7 commits into from Nov 21, 2020

Conversation

JillianK
Copy link
Contributor

@JillianK JillianK commented Nov 9, 2020

Adds any sprites from the default sprite list that are missing from a project's initial sprites (generally because the defaultSprites have changed since its creation)
Also adds extra logic to check for missing sprites after filtering by category to prevent the new sprite block and the background block from breaking.

This is necessary before we add the block to the toolbox.

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@JillianK JillianK requested a review from a team November 9, 2020 20:16
@JillianK JillianK merged commit a31f211 into staging Nov 21, 2020
@JillianK JillianK deleted the jk-spritelab-background-backwards-compatibility branch November 21, 2020 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants