-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade bramble to 0.1.29 #36710
Closed
Closed
Upgrade bramble to 0.1.29 #36710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddiedierker
commented
Sep 11, 2020
@@ -345,6 +345,10 @@ function uploadAllFilesFromBramble(callback) { | |||
}); | |||
} | |||
|
|||
function fileRefresh(callback) { | |||
brambleProxy_.fileRefresh(callback); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added fileRefresh
to the bramble API in this commit
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR
As of writing this, the changes in this PR are available on this adhoc.
fileRefresh
method from bramble (added in this commit). This is necessary when uploading a new image because images are managed outside of bramble, so we need to tell bramble to refresh the file tree UI after an image file is added to the tree.Follow-up Work
Links
Testing story
There are existing UI/eyes tests to make sure bramble loads when a user visits weblab. UI tests are still working as expected, and eyes tests will definitely need to be resolved.
Reviewer Checklist: