Remove @code-dot-org/bramble package, load bramble from S3 package #38374
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes our
@code-dot-org/bramble
NPM package dependency. As far as I can tell, it was only used for loadingrequire.min.js
when loading WebLab:code-dot-org/dashboard/app/views/weblab_host/index.html.haml
Line 10 in 9bf9e58
However, we point to the S3 build when we instantiate Bramble:
code-dot-org/apps/src/weblab/brambleHost.js
Lines 599 to 600 in 9bf9e58
This means WebLab actually uses the S3 build, not the NPM package, so I have removed the NPM package. I will need to do some follow-up work to indicate this in code-dot-org/bramble (there are currently no Code.org-specific instructions around how to publish/consume a new version of Bramble, so I've added them here).
These changes were previously part of #36710 (general "upgrade Bramble" PR), but I realized that this change can and should ship on its own to make sure there are no regressions prior to upgrading.
I also did some clean-up around "dev mode" because you had to comment/un-comment like 4 different things in different spots before. Now, if you set
@dev_mode
to true inWeblabHostController
, everything will point to your local Bramble server.Links
Testing story
Relies on existing UI tests, which make sure that Bramble loads properly.
Reviewer Checklist: