New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I18n sync Down & Out 12/01 #38065
I18n sync Down & Out 12/01 #38065
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, assuming we've verified that all the strings we care about are present
@castro-jorge says it looks like we're missing this string: https://crowdin.com/translate/codeorg/56/enus-ar?filter=advanced&value=12&sort_ascending=1#2474860 |
@dju90 is this the string you're talking about? 36f1753#diff-be25c611b8ac55e9e938010b0def1f7a92ed06857bc24b5769aa65a1cb9b7934R1523 |
I18n Sync Down & Out
This PR contains all changes to translations made since the last sync (usually a week).
To Review:
Look through the changes in each of the commits and verify that all changes are expected. Note that it is not necessary to review every single "dashboard i18n update" commit. These commits are batched by language to make it easier to review just a couple commits in this category.
Things to Note:
We expect translation changes to come in on a regular basis; new strings will be translated, existing translations will be updated, and source string removals will result in translations for those strings also being removed.
We expect translations to arrive in large batches, so don't worry if you see a large group of changes in a specific language.
We do not usually expect to see a large number of formatting changes, or batches of changes that apply to strings in every single language. If you see this, it usually means either that a code change went in or that something broke.
Known Issues:
If the CI unit tests fail at the
grunt messages:all
step, they will typically fail with a message like:This usually means that a translator has translated one of the MessageFormat variables. In this case, you should find and fix the offending translation in crowdin, and then manually update the associated strings in
i18n/locales
andapps/i18n
.See ab3e5d1 and 0fca376 for an example.
To Deploy:
Once one or two people have reviewed and approved this change and the tests are passing, ship it!
It's not necessary to wait for everyone on the team to review.