[Spritelab] Implement Pause button behind experiment #38457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -192,6 +193,9 @@ class P5LabVisualizationColumn extends React.Component { | |||
| </div> | |||
|
|
|||
| <GameButtons> | |||
| {experiments.isEnabled(experiments.SPRITELAB_PAUSE) && ( | |||
There was a problem hiding this comment.
this checks localStorage every time the component renders, which has caused performance issues in the past, so it should be moved to a piece of state set during componentDidMount or stored in some other way (memoized or something similar would also work)
apps/src/templates/PauseButton.jsx
Outdated
| togglePause = () => { | ||
| const current = new Date().getTime(); | ||
| if (this.props.isPaused) { | ||
| coreLibrary.addPauseTime(current - this.state.pauseStart); |
There was a problem hiding this comment.
this function should probably be a prop so that PauseButton doesn't depend on coreLibrary and can be reused
maddiedierker
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress/prototype for the ability to pause spritelab execution
This mostly hooks into the existing break/pause functionality in gamelab.
Behind an experiment (
spritelabPause) for now mostly so that curriculum writers can start playing with it / writing lessons as we continue to iterate together.Not done yet:
Links
Testing story
Reviewer Checklist: