-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spritelab] Implement Pause button behind experiment #38457
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2855343
make the button
ajpal 32beb7d
hook up to jsdebugger redux
ajpal e2a64df
account for pause time in the spritelab library
ajpal 7e0ae3b
Merge branch 'staging' into jan7-spritelab-pause
ajpal 9da4770
check experiments in constructor
ajpal 361c287
pass through pauseHandler as prop
ajpal File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
import React from 'react'; | ||
import {connect} from 'react-redux'; | ||
import PropTypes from 'prop-types'; | ||
import color from '@cdo/apps/util/color'; | ||
import {actions, selectors} from '@cdo/apps/lib/tools/jsdebugger/redux'; | ||
import * as coreLibrary from '@cdo/apps/p5lab/spritelab/coreLibrary'; | ||
|
||
const styles = { | ||
button: { | ||
minWidth: 0, | ||
padding: '10px 13px', | ||
backgroundColor: color.orange, | ||
borderColor: color.orange, | ||
color: color.white | ||
} | ||
}; | ||
|
||
class PauseButton extends React.Component { | ||
static propTypes = { | ||
// from redux | ||
togglePause: PropTypes.func.isRequired, | ||
isPaused: PropTypes.bool.isRequired, | ||
isAttached: PropTypes.bool.isRequired | ||
}; | ||
|
||
state = { | ||
pauseStart: 0 | ||
}; | ||
|
||
togglePause = () => { | ||
const current = new Date().getTime(); | ||
if (this.props.isPaused) { | ||
coreLibrary.addPauseTime(current - this.state.pauseStart); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this function should probably be a prop so that PauseButton doesn't depend on coreLibrary and can be reused |
||
this.setState({pauseStart: 0}); | ||
} else { | ||
this.setState({pauseStart: current}); | ||
} | ||
this.props.togglePause(); | ||
}; | ||
|
||
render() { | ||
return ( | ||
<button | ||
type="button" | ||
onClick={this.togglePause} | ||
style={styles.button} | ||
disabled={!this.props.isAttached} | ||
> | ||
<i className={this.props.isPaused ? 'fa fa-play' : 'fa fa-pause'} /> | ||
</button> | ||
); | ||
} | ||
} | ||
|
||
export default connect( | ||
state => ({ | ||
isAttached: selectors.isAttached(state), | ||
isPaused: selectors.isPaused(state) | ||
}), | ||
{ | ||
togglePause: actions.togglePause | ||
} | ||
)(PauseButton); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this checks localStorage every time the component renders, which has caused performance issues in the past, so it should be moved to a piece of state set during
componentDidMount
or stored in some other way (memoized or something similar would also work)