-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown fixes for imported CurriculumBuilder content #38669
Changes from 7 commits
702d0af
7910395
629e988
910bca9
87d96a9
5448765
9244715
8c3b363
91a1e5d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5031,7 +5031,7 @@ | |
"key": "98d19496-66aa-42da-b213-0041a105222f", | ||
"position": 2, | ||
"properties": { | ||
"description": "**Discuss:** Have students share their observations and analyses of the program. \r\n\r\nEncourage the class to consider that there are multiple approaches to programming anything, but that there may be clues as to how something was created. In particular, when they are sharing their thoughts ask them to specify the following :\r\n\r\n* Clues that suggest a sprite was used\r\n* Clues that suggest a conditional was used\r\n* Clues that suggest an iterator pattern was used\r\n\r\n**Display:** Show students the rubric. Review the different components of the rubric with them to make sure they understand the components of the project.\r\n\r\n\r\n**Question of the Day: What skills and practices are important when creating an interactive program?**" | ||
"description": "**Discuss:** Have students share their observations and analyses of the program. \n\nEncourage the class to consider that there are multiple approaches to programming anything, but that there may be clues as to how something was created. In particular, when they are sharing their thoughts ask them to specify the following:\n\n* Clues that suggest a sprite was used\n* Clues that suggest a conditional was used\n* Clues that suggest an iterator pattern was used\n\n**Display:** Show students the rubric. Review the different components of the rubric with them to make sure they understand the components of the project.\n\n\n**Question of the Day: What skills and practices are important when creating an interactive program?**" | ||
}, | ||
"seeding_key": { | ||
"activity_section.key": "98d19496-66aa-42da-b213-0041a105222f", | ||
|
@@ -5054,7 +5054,7 @@ | |
"key": "9ba73a20-ba7f-42ae-9360-0b5607bd0498", | ||
"position": 4, | ||
"properties": { | ||
"description": "&fa-desktop; **Transition: **Once students have completed their planning sheet, it's time to head to the Code.org website. The short level sequence asks students to complete each element of their project.", | ||
"description": "**Transition:** Once students have completed their planning sheet, it's time to head to the Code.org website. The short level sequence asks students to complete each element of their project.", | ||
"name": " Levels: Implementing Interactive Card (Level 3 - 7)\r" | ||
}, | ||
"seeding_key": { | ||
|
@@ -5090,7 +5090,7 @@ | |
"key": "b2ad1d43-99f9-40fa-9f88-d8b42f8c723e", | ||
"position": 7, | ||
"properties": { | ||
"description": "Using the rubric, students should assess their own project before submitting it.\r\n\r\n\r\n&fa-desktop; Send students to Code Studio to complete their reflection on their attitudes toward computer science. Although their answers are anonymous, the aggregated data will be available to you once at least five students have completed the survey.", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't know if we ever came to a consensus on whether to support There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In this specific case, it looked like it was being used to display the "there's a tip" icon, which of course with the new system is automatically showing up when a "tip" is present. I did also notice these fontawesome icons in a couple of other places and left them untouched, assuming that we'd get to them as part of the larger "special CB syntaxes" effort There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think they were used to indicate that students should move to the computer at that point There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ya fa-desktop was used to mark where there was a transition onto the computer. I think when we talked to the curriculum team they didn't seem attached to it There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think if we didn't remove all the fa-desktops we should keep these ones and double check with curriculum before removing them all at once. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ahhh, I definitely misunderstood what this one was being used for, then. I'll put it back for now |
||
"description": "Using the rubric, students should assess their own project before submitting it.\n\nSend students to Code Studio to complete their reflection on their attitudes toward computer science. Although their answers are anonymous, the aggregated data will be available to you once at least five students have completed the survey.", | ||
"name": "Reflect\r" | ||
}, | ||
"seeding_key": { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to use a different tool to see what changed on this line:
are there next steps that need to be tracked for this image, whose width is being removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope; in this case, the image being used never needed to be a size other than its display size, so I just resized the actual image. See the commit description 7910395