I18n translations for fnd 1431 #40410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dju90
reviewed
May 5, 2021
apps/i18n/common/en_us.json
Outdated
| @@ -1169,6 +1172,8 @@ | |||
| "manageStudentsNotificationAtCapacity": "You can’t have more than 500 students in a section. Questions about this limit? [Contact support](https://code.org/contact)", | |||
| "manageStudentsNotificationAddSuccess": "You added {numStudents, plural, one {1 student} other {# students}} to your section.", | |||
| "manageStudentsNotificationSuccess": "Success!", | |||
| "manageStudentsNotificationLocked": "You have locked this section", | |||
| "manageStudentsNotificationLockedDetails": "Students can not join this section using the section code. {loginType, select, email {You can still add students to the section manually by moving or copying them from another section} other {You can still add students manually on the Manage Students tab}}. You can unlock this section by clicking \"Edit Section Details\".", | |||
There was a problem hiding this comment.
Nit: "can not" should be one word: "cannot"
There was a problem hiding this comment.
Thank you! Just pushed a fix for that typo
dju90
approved these changes
May 5, 2021
JamesHankinsDev
force-pushed
the
i18n-translations-for-FND-1431
branch
from
438bae4
to
1615043
Compare
hacodeorg
reviewed
May 6, 2021
There was a problem hiding this comment.
You don't have to check in the changes in dashboard/db/schema_cache.yml.
It is taken care by the CI/CD pipeline https://github.com/code-dot-org/code-dot-org/commits/3ffbc6d787350a7e6b0b41d2000af16456adc3d0/dashboard/db/schema_cache.yml
| @@ -3980,7 +3980,7 @@ en: | |||
| description_student: In this lesson the class develops a preliminary definition of a computer. After brainstorming the possible definitions for a computer, the class works in groups to sort pictures into “is a computer” or “is not a computer” on poster paper and explain their motivations for choosing some of the most difficult categorizations. The teacher then introduces a definition of the computer and allows groups to revise their posters according to the new definition. | |||
| description_teacher: 'In this lesson students develop a preliminary definition of a computer. To begin the lesson, the class will brainstorm possible definitions for a computer and place the results of this brainstorm on the board. Next, students will work in groups to sort pictures into “is a computer” or “is not a computer” on poster paper. Groups will place their posters around the room and briefly explain their motivations for choosing some of their most difficult categorizations. The teacher will then introduce a definition of the computer and allow students to revise their posters according to the new definition. | |||
|
|
|||
| ' | |||
| ' | |||
There was a problem hiding this comment.
Why are there so many space changes in this file?
There was a problem hiding this comment.
Sorry about that - just pulled the scripts.en.yml file out
hacodeorg
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mall PR to add i18n strings for FND-1431: Lock Section
Adds required strings to React and Rails i18n files
apps/i18n/common/en_us.jsonimplements for React,dashboard/config/locales/en.ymlimplements for Rails**NOTE: This sets up strings to be included in feature branch FND-1431: Section Lock and should be reviewed/approved/merged first.
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: