Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P5Lab] Move and rename animation metadata scripts #40665

Merged
merged 1 commit into from May 24, 2021

Conversation

ajpal
Copy link
Contributor

@ajpal ajpal commented May 18, 2021

Another pure refactor. Just renaming from camelCase to snake_case because these are Ruby scripts. Also moving from code-dot-org/tools/scripts to code-dot-org/bin/animation_assets, which I think will make these easier to find moving forward.

Links

jira

Testing story

Just moving existing scripts, so no additional tests. As a sanity check, I ran rebuild_animation_metadata for spritelab just to make sure it still worked. I didn't test all the scripts, though.

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@ajpal ajpal requested a review from a team May 18, 2021 21:13
Copy link

@epeach epeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This is going to confuse my Javascript-based brain, but it's definitely good to align with standards here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants