Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javalab backpack dropdown #40785

Merged
merged 5 commits into from May 28, 2021
Merged

Javalab backpack dropdown #40785

merged 5 commits into from May 28, 2021

Conversation

JillianK
Copy link
Contributor

@JillianK JillianK commented May 26, 2021

Update the backpack button to use a backpack icon, create a dropdown menu with dummy filenames on button click with an import button.

Screen Shot 2021-05-26 at 2 43 11 PM

Screen Shot 2021-05-26 at 2 43 07 PM

Screen Shot 2021-05-26 at 2 49 09 PM

Update: light mode
Screen Shot 2021-05-27 at 1 30 24 PM

Design from Figma
Screen Shot 2021-05-26 at 2 52 31 PM

Links

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Copy link
Contributor

@molly-moen molly-moen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a couple nits/questions

apps/src/javalab/Backpack.jsx Outdated Show resolved Hide resolved
apps/src/javalab/Backpack.jsx Outdated Show resolved Hide resolved
apps/src/javalab/Backpack.jsx Outdated Show resolved Hide resolved
<span>Backpack</span>
</button>

{dropdownOpen && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this work for both light and dark mode?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it does!
Screen Shot 2021-05-27 at 1 30 24 PM

apps/src/javalab/Backpack.jsx Outdated Show resolved Hide resolved
apps/src/javalab/Backpack.jsx Outdated Show resolved Hide resolved
apps/src/javalab/Backpack.jsx Outdated Show resolved Hide resolved
Base automatically changed from jk-ui-fixes to staging May 27, 2021 16:43
Copy link
Contributor

@molly-moen molly-moen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@JillianK JillianK merged commit 9efbfc6 into staging May 28, 2021
@JillianK JillianK deleted the jk-backpack-dropdown branch May 28, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants