Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deckofcardsapi and api.quotable.io #43189

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Conversation

KylieModen
Copy link
Contributor

Both hostnames requested via Zendesk (https://codeorg.zendesk.com/agent/tickets/357817) and (https://codeorg.zendesk.com/agent/tickets/357410)

References:
https://deckofcardsapi.com/
https://api.quotable.io/random and https://github.com/lukePeavey/quotable

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@KylieModen KylieModen requested a review from a team October 26, 2021 17:16
Copy link

@epeach epeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, as long as we aren't worried about the content of the quotes?

@KylieModen
Copy link
Contributor Author

Looks good, as long as we aren't worried about the content of the quotes?

I reviewed the quotes contents and no inappropriate content or curse words was found. Ultimately risk seemed low compared to joke apis that did have inappropriate content. This quote API is focused on historical�/important quotes.

@KylieModen KylieModen merged commit c64a8a7 into staging Oct 26, 2021
@KylieModen KylieModen deleted the KylieModen-patch-2 branch October 26, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants