Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make behavior blocks translatable in Authored Hints #43573

Merged
merged 17 commits into from
Nov 18, 2021
Merged

Make behavior blocks translatable in Authored Hints #43573

merged 17 commits into from
Nov 18, 2021

Conversation

daynew
Copy link
Member

@daynew daynew commented Nov 12, 2021 •
edited

The descriptions box for each level has a button students can click in order to get hints about what to do next. These hints are a field called authored_hints. This is markdown text which can have embedded blockly XML. This PR addresses the issue that parts of blockly blocks in the authored_hints are not being translated.

Links

Testing story

  • Unit tests
  • Generated a before:after diff of the authored_hints across 100 levels. I spot checked and fixed any issues with my solution I found.

Screenshots

Before

Note that wander is English.
image

After

Note that wander is now deambulando
Screen Shot 2021-11-16 at 11 24 07 PM

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

smusoke and others added 9 commits November 11, 2021 16:36
@smusoke
feat: short and long instrructions placeholder texts translated
602f626
@daynew
Temporarily saving work on translating blockly in author_hints
37491f1
@smusoke
feat: remove wrapping elements when processing markdown. test: unit t…
b251e82 
…est for localizing markdown
@smusoke
feat: refactor of markdown localization. Removing p tags seemed probl…
57406a1 
…ematic in the case we actually want to use one. This should work just the same
@smusoke
docs: updated comments
1b87fee
@smusoke
docs: more docs for clarity
735e1b7
@daynew
Merge branch 'staging' of github.com:code-dot-org/code-dot-org into f…
cdd1d21 
…nd-1769-hints-show-translated-behav-blocks
@daynew
Merge remote-tracking branch 'origin/fnd-1771-print-text-placeholder-…
49c9b2b 
…translations' into fnd-1769-hints-show-translated-behav-blocks
@daynew
Cleaned up the code and added unit tests
fc6dd47
@daynew daynew changed the base branch from staging to fnd-1771-print-text-placeholder-translations November 17, 2021 07:29
@daynew daynew changed the base branch from fnd-1771-print-text-placeholder-translations to staging November 17, 2021 07:35
@daynew
Revert "docs: more docs for clarity"
39c4466 
This reverts commit 735e1b7.
@daynew
Revert "docs: updated comments"
6ad38e2 
This reverts commit 1b87fee.
@daynew
Revert "feat: refactor of markdown localization. Removing p tags seem…
703f295 
…ed problematic in the case we actually want to use one. This should work just the same"

This reverts commit 57406a1.
@daynew
Revert "feat: remove wrapping elements when processing markdown. test…
7be248b 
…: unit test for localizing markdown"

This reverts commit b251e82.
@daynew
Revert "feat: short and long instrructions placeholder texts translated"
b6133ae 
This reverts commit 602f626.
@smusoke smusoke mentioned this pull request Nov 17, 2021
Merged
8 tasks
@daynew daynew marked this pull request as ready for review November 17, 2021 20:26
@daynew daynew changed the title Temporarily saving work on translating blockly in author_hints Make behavior blocks translatable in Authored Hints Nov 17, 2021
@daynew daynew requested a review from a team November 17, 2021 21:53
@daynew daynew merged commit 6296140 into staging Nov 18, 2021
@daynew daynew deleted the fnd-1769-hints-show-translated-behav-blocks branch November 18, 2021 07:05
daynew added a commit that referenced this pull request Nov 19, 2021
@daynew
Revert "Merge pull request #43573 from code-dot-org/fnd-1769-hints-sh…
16b6002 
…ow-translated-behav-blocks"

This reverts commit 6296140, reversing
changes made to b7cb793.
@daynew daynew mentioned this pull request Nov 19, 2021
Merged
8 tasks
snickell pushed a commit that referenced this pull request Feb 3, 2024
@daynew
Merge pull request #43573 from code-dot-org/fnd-1769-hints-show-trans…
37267b4 
…lated-behav-blocks

Make behavior blocks translatable in Authored Hints
snickell pushed a commit that referenced this pull request Feb 3, 2024
@daynew
Revert "Merge pull request #43573 from code-dot-org/fnd-1769-hints-sh…
d619445 
…ow-translated-behav-blocks"

This reverts commit 6296140, reversing
changes made to b7cb793.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smusoke smusoke smusoke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daynew @smusoke