-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Placeholder text support for level short/long instructions and authored hints #43575
Placeholder text support for level short/long instructions and authored hints #43575
Conversation
…est for localizing markdown
…ematic in the case we actually want to use one. This should work just the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a minor comment about testing.
@@ -567,6 +567,49 @@ def create_custom_block(name, pool, block_text, args, category: 'Events') | |||
assert_equal expected_localized_block_xml, localized_block_xml | |||
end | |||
|
|||
test 'localized_markdown_with_placeholder_texts' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it would be too much hassle to add long_instructions
and short_instructions
to the level we are creating in this test, and then call them to verify that those properties are actually get translated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added 👍
…nd-1769-hints-show-translated-behav-blocks
…translations' into fnd-1769-hints-show-translated-behav-blocks
This reverts commit 735e1b7.
This reverts commit 1b87fee.
…ed problematic in the case we actually want to use one. This should work just the same" This reverts commit 57406a1.
…: unit test for localizing markdown" This reverts commit b251e82.
This reverts commit 602f626.
…t-placeholder-translations
…merging daynes PR
…support authored hints
…ehav-blocks' into fnd-1771-print-text-placeholder-translations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks even better now!
…holder-translations Placeholder text support for level short/long instructions and authored hints
What:
This PR was worked on simultaneously and merged its branch into this one. Giving us
authored_hint
support for (virtually)free!sync-in.rb
to parseshort_instructions
,long_instructions
, andauthored_hints
for placeholder text block's.blockly.rb
.Why: This will allow for placeholder text blocks to be integrated into the translation pipeline and translated for these level properties moving forward.
Links
Testing story
sync-in
localized_blockly_in_text
method on every level's relevant markdown property.blockly
modelDeployment strategy
Merge after #43573
Follow-up work
Similar updates to provide support for validation text.
https://codedotorg.atlassian.net/browse/FND-1771
PR Checklist: