Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Azerbaijani translation #44754

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Fix Azerbaijani translation #44754

merged 1 commit into from
Feb 10, 2022

Conversation

epeach
Copy link

@epeach epeach commented Feb 10, 2022

Same issue as #44752

This translations don't seem to work (one has the wrong format and one has the wrong number of parameters) so moving them back to English so that SpriteLab can load. The corresponding changes aren't made in CrowdIn so this will revert unless we can make the same change in CrowdIn. https://codedotorg.slack.com/archives/C0T0PNTM3/p1644455394055839

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@epeach epeach requested a review from a team as a code owner February 10, 2022 01:48
@epeach epeach requested a review from a team February 10, 2022 01:48
Copy link
Member

@breville breville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with this syntax, but if it's a reversion to original and works, then seems good.

@epeach epeach mentioned this pull request Feb 10, 2022
8 tasks
@epeach epeach merged commit 6d0e1a3 into staging Feb 10, 2022
@epeach epeach deleted the fix-translations-az branch February 10, 2022 17:11
@epeach epeach mentioned this pull request Feb 10, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants