Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Armenian Translations #44757

Merged
merged 2 commits into from
Feb 10, 2022
Merged

Fix Armenian Translations #44757

merged 2 commits into from
Feb 10, 2022

Conversation

epeach
Copy link

@epeach epeach commented Feb 10, 2022

Fixed on CrowdIn already: https://codedotorg.slack.com/archives/C0T0PNTM3/p1644458285773989?thread_ts=1644455394.055839&cid=C0T0PNTM3

Similar issue to #44754 - translation error was causing SpriteLab not to load.

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@epeach epeach requested a review from a team February 10, 2022 02:48
@@ -249,7 +249,7 @@ Blockly.Msg.MATH_RANDOM_FLOAT_HELPURL = "http://en.wikipedia.org/wiki/Random_num
Blockly.Msg.MATH_RANDOM_FLOAT_TITLE_RANDOM = "պատահական մասն";
Blockly.Msg.MATH_RANDOM_FLOAT_TOOLTIP = "Վերադարձնել պատահական խմբակցության միջեւ 0.0 (ներառյալ) եւ 1.0 (բացառիկ):";
Blockly.Msg.MATH_RANDOM_INT_HELPURL = "http://en.wikipedia.org/wiki/Random_number_generation";
Blockly.Msg.MATH_RANDOM_INT_TITLE = "Պատահական ամբողջ թիվ է% 1% 2";
Blockly.Msg.MATH_RANDOM_INT_TITLE = "Պատահական ամբողջ թիվ է% %1 %2";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, is the % before the %1 possibly a stray one that should be removed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put this is google translate and I think you are correct. Editing now.

@epeach epeach merged commit a005dad into staging Feb 10, 2022
@epeach epeach deleted the fix-translations-armenian branch February 10, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants