Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename constants to include _PROJECT_TYPES suffix in StartNewProject.jsx #45742

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Rename constants to include _PROJECT_TYPES suffix in StartNewProject.jsx #45742

merged 1 commit into from
Apr 8, 2022

Conversation

mikeharv
Copy link
Contributor

@mikeharv mikeharv commented Apr 8, 2022

Suggested as part of:

@breville said:

Just an idea: should we prefix/suffix all of these with something like _PROJECT_TYPES?

This is an easy change that hopefully improves the readability of StartNewProject.jsx.

@mikeharv mikeharv requested a review from a team April 8, 2022 14:20
@mikeharv mikeharv merged commit 823c19d into staging Apr 8, 2022
@mikeharv mikeharv deleted the mike/rename-consts-for-project-types branch April 8, 2022 14:24
@mikeharv mikeharv mentioned this pull request Apr 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breville breville breville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikeharv @breville