New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bad Guys] Reorder projects page #45566
Conversation
(Is this ready for review or still a draft?) |
This is still technically a draft because I'm waiting for T&L approval for the new categories. I'll ping the team when ready, and perhaps not add reviewers until then next time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - order reviewed in T&L meeting
Can you add a note that points of the differences between the under13/over13 images? It's a bit hard to see the differences. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
]; | ||
|
||
const defaultProjectTypes = canViewAdvancedTools | ||
? DEFAULT_PROJECT_TYPES_ADVANCED | ||
: DEFAULT_PROJECT_TYPES_BASIC; | ||
|
||
const OPEN_ENDED = ['spritelab', 'dance', 'poetry', 'thebadguys']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving these lists to global variables is a really good clean-up!
@epeach Added annotations to images to highlight differences! |
]; | ||
|
||
const defaultProjectTypes = canViewAdvancedTools | ||
? DEFAULT_PROJECT_TYPES_ADVANCED | ||
: DEFAULT_PROJECT_TYPES_BASIC; | ||
|
||
const OPEN_ENDED = ['spritelab', 'dance', 'poetry', 'thebadguys']; | ||
|
||
const DRAWING = ['artist', 'frozen']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an idea: should we prefix/suffix all of these with something like _PROJECT_TYPES
?
Builds on the work started in:
We need to enable starting new "The Bad Guys" projects on the Projects Page and reorder existing projects. @KylieModen and I also think it makes sense to update the default set of projects for under 13 users not in sections.
The new categories presented here were shared at the 3/31/21 T+L+P+E sync and approved by those in attendance.
Proposed project categories for users who are 13 or over or in a section:
Proposed project categories for users who are under 13 and not in a section:
Note: Today, thedefault list for these users includes Poetry and Minecraft Designer instead of Play Lab.
Links
jira tickets: