Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bad Guys] Reorder projects page #45566

Merged
merged 4 commits into from Mar 31, 2022
Merged

[Bad Guys] Reorder projects page #45566

merged 4 commits into from Mar 31, 2022

Conversation

mikeharv
Copy link
Contributor

@mikeharv mikeharv commented Mar 30, 2022

Builds on the work started in:

We need to enable starting new "The Bad Guys" projects on the Projects Page and reorder existing projects. @KylieModen and I also think it makes sense to update the default set of projects for under 13 users not in sections.

The new categories presented here were shared at the 3/31/21 T+L+P+E sync and approved by those in attendance.

Proposed project categories for users who are 13 or over or in a section:
160919723-ae2602b1-fff0-4fc1-b1ae-b71d7f2a6031161104094-a44d72f2-6559-4434-8123-6c44a975ed4f

Proposed project categories for users who are under 13 and not in a section:
160919773-95a305aa-0bc7-4612-83c5-b4c0f9fadf73

Note: Today, thedefault list for these users includes Poetry and Minecraft Designer instead of Play Lab.
160919849-fa264c47-eb26-4e6b-aa2d-34ac58cf9de4

Links

jira tickets:

@mikeharv mikeharv requested a review from a team March 30, 2022 17:54
@mikeharv mikeharv changed the base branch from staging to thebadguys-initial-publish-support-project-tile March 30, 2022 17:54
Base automatically changed from thebadguys-initial-publish-support-project-tile to staging March 30, 2022 19:17
@epeach
Copy link

epeach commented Mar 30, 2022

(Is this ready for review or still a draft?)

@mikeharv
Copy link
Contributor Author

(Is this ready for review or still a draft?)

This is still technically a draft because I'm waiting for T&L approval for the new categories. I'll ping the team when ready, and perhaps not add reviewers until then next time.

@mikeharv mikeharv marked this pull request as ready for review March 31, 2022 16:32
@mikeharv mikeharv requested a review from a team as a code owner March 31, 2022 16:32
@mikeharv mikeharv requested review from KylieModen and a team and removed request for a team and KylieModen March 31, 2022 16:32
Copy link
Contributor

@KylieModen KylieModen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - order reviewed in T&L meeting

@epeach
Copy link

epeach commented Mar 31, 2022

Can you add a note that points of the differences between the under13/over13 images? It's a bit hard to see the differences. Thanks!

Copy link

@epeach epeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

];

const defaultProjectTypes = canViewAdvancedTools
? DEFAULT_PROJECT_TYPES_ADVANCED
: DEFAULT_PROJECT_TYPES_BASIC;

const OPEN_ENDED = ['spritelab', 'dance', 'poetry', 'thebadguys'];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving these lists to global variables is a really good clean-up!

@mikeharv
Copy link
Contributor Author

Can you add a note that points of the differences between the under13/over13 images? It's a bit hard to see the differences. Thanks!

@epeach Added annotations to images to highlight differences!

@epeach
Copy link

epeach commented Mar 31, 2022

thanks

@mikeharv mikeharv merged commit f26c5d2 into staging Mar 31, 2022
@mikeharv mikeharv deleted the mike/projects-page-updates branch March 31, 2022 20:06
];

const defaultProjectTypes = canViewAdvancedTools
? DEFAULT_PROJECT_TYPES_ADVANCED
: DEFAULT_PROJECT_TYPES_BASIC;

const OPEN_ENDED = ['spritelab', 'dance', 'poetry', 'thebadguys'];

const DRAWING = ['artist', 'frozen'];
Copy link
Member

@breville breville Apr 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an idea: should we prefix/suffix all of these with something like _PROJECT_TYPES?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants