Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo "Rename constants to include _PROJECT_TYPES suffix in StartNewProject.jsx" #45744

Conversation

mikeharv
Copy link
Contributor

@mikeharv mikeharv commented Apr 8, 2022

Redoes #4572 (Reverts #45743)
I goofed and didn't wait for drone to finish the first time. I'll be more patient this time.

Suggested as part of:

@breville said:

Just an idea: should we prefix/suffix all of these with something like _PROJECT_TYPES?

This is an easy change that hopefully improves the readability of StartNewProject.jsx.

@mikeharv mikeharv requested a review from breville April 8, 2022 14:54
@mikeharv mikeharv merged commit a739194 into staging Apr 8, 2022
@mikeharv mikeharv deleted the revert-45743-revert-45742-mike/rename-consts-for-project-types branch April 8, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants