Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Unused sdoc Dependency #46372

Merged
merged 1 commit into from May 17, 2022
Merged

Remove Unused sdoc Dependency #46372

merged 1 commit into from May 17, 2022

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented May 16, 2022 •
edited

I can't find anywhere we use the sdoc gem, the doc bundle group, the doc:rails rake command, or whatever "doc/api" refers to.

The sdoc gem also pins us to version ~> 1.7 of the json gem, which is hampering our ability to upgrade to Ruby 2.7. Removing this unused dependency to clear that up.

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@Hamms Hamms mentioned this pull request May 16, 2022
Merged
8 tasks
@Hamms Hamms added the Ruby Update Everything related to work to update the version of Ruby our codebase runs on label May 17, 2022
@Hamms Hamms marked this pull request as ready for review May 17, 2022 00:02
@Hamms Hamms requested a review from a team May 17, 2022 00:02
@Hamms Hamms merged commit d9d07d9 into staging May 17, 2022
@Hamms Hamms deleted the remove-sdoc branch May 17, 2022 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sureshc sureshc sureshc approved these changes

Assignees
No one assigned
Labels
Ruby Update Everything related to work to update the version of Ruby our codebase runs on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hamms @sureshc