Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update json Gem to 2.6.2 #46373

Merged
merged 6 commits into from May 31, 2022
Merged

Update json Gem to 2.6.2 #46373

merged 6 commits into from May 31, 2022

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented May 16, 2022 •
edited

Required for the Ruby 2.7 upgrade.

There are no official breaking changes between versions 1.8.6 and 2.6.2 other than removal of support for versions of Ruby < 2.0.

However, there is one behavioral change - arguably, a behavioral fix - which adds the ability to parse JSON Scalars as well as Arrays and Objects. See https://stackoverflow.com/questions/18419428/what-is-the-minimum-valid-json/18419503#18419503 for more context

Links

json gem changelog

Depends on:

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@Hamms Hamms mentioned this pull request May 18, 2022
Merged
8 tasks
@Hamms Hamms added the Ruby Update Everything related to work to update the version of Ruby our codebase runs on label May 27, 2022
@Hamms Hamms marked this pull request as ready for review May 27, 2022 20:16
@Hamms Hamms requested a review from a team May 27, 2022 20:16
@Hamms Hamms merged commit c8145f3 into staging May 31, 2022
@Hamms Hamms deleted the json-2.6.2 branch May 31, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cat5inthecradle cat5inthecradle cat5inthecradle approved these changes

Assignees
No one assigned
Labels
Ruby Update Everything related to work to update the version of Ruby our codebase runs on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hamms @cat5inthecradle