DTL (Test > Levelbuilder): 04af819b #46582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've got some custom JSON-parsing logic in our AWS Secrets Manager interface. Specifically, custom logic which in addition to wrapping parsed JSON Objects in fancy Ruby accessor helpers will nicely handle values which cannot be parsed to JSON by simply returning them directly.
Unfortunately, the current version of the JSON gem we're using does not support parsing scalar values:
```
[development] dashboard > JSON.parse("123")
Traceback (most recent call last):
1: from (irb):1
JSON::ParserError (784: unexpected token at '123')
[development] dashboard > JSON.parse("1.0")
Traceback (most recent call last):
1: from (irb):2
JSON::ParserError (784: unexpected token at '1.0')
```
I'm not sure why this is; this behavior is (as far as I can find) undocumented and entirely undesirable. The version of the JSON gem to which we'd like to upgrade as part of the Ruby 2.7 upgrade has the expected behavior:
```
[development] dashboard > JSON.parse("123")
=> 123
[development] dashboard > JSON.parse("1.0")
=> 1.0
[development] dashboard >
```
Which for the most part is a good thing, but does break the behavior here. I'm not entirely sure of the best way to preserve the existing behavior; or, indeed, if we even _want_ to preserve the existing behavior. Open to suggestions!
…ts-ability Code review v2 clean-up
…eview Handle deleted user accounts for code review
Reinforce Custom JSON Parsing Logic
DTT (Staging > Test) [robo-dtt]
Create DELETE /code_review_notes/:id
DTT (Staging > Test) [robo-dtt]
…rora-engine Upgrade non-production Aurora Engine version to latest Patch release
…tion Configure non-production database clusters to match production cluster.
DTT (Staging > Test) [robo-dtt]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.