-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DTL (Test > Levelbuilder): d67700b8 #48004
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To pick up support for Rails 6.1, which [was added in 1.0.3](https://github.com/zdennis/activerecord-import/blob/master/CHANGELOG.md#changes-in-103)
Rails 6.1 (specifically, rails/rails#36478) changed this method to no longer accept a catchall options object and to instead use specific keyword arguments. This change reveals that we have been passing a keyword argument which is not actually used, so in this PR we stop passing it.
…iciate change of MAX_NUM_SPRITE constant
…s' into workspace_alert_sprite_lab
Make code review scenarios an eyes test
…-import-1.0.8 Revert "Update `activerecord-import` Gem"
…on-to-i18n adding "add New Animation..." raw string to i18n
…review_comments_code
DTT (Staging > Test) [robo-dtt]
…ashcan Google Blockly: place trashcan correctly in RTL languages
DTT (Staging > Test) [robo-dtt]
DTS (Levelbuilder > Staging) [elijah]
DTT (Staging > Test) [robo-dtt]
…comments_code Delete all remaining code_review_comment code
Update the test environment's hoc_mode to "pre-hoc".
DTT (Staging > Test) [robo-dtt]
…hread Remove Unnecessary `lock_thread` Argument
DTT (Staging > Test) [robo-dtt]
…ode-to-pre-hoc hoc2022: Update test hoc_mode to pre-hoc
DTT (Staging > Test) [robo-dtt]
DTT (Staging > Test) [robo-dtt]
DTT (Staging > Test) [robo-dtt]
remove mini_racer gem from development environment
DTT (Staging > Test) [robo-dtt]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.