Add ariaLabel prop to PaneButton for icon-only buttons #49529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megcrenshaw
reviewed
Dec 14, 2022
| @@ -161,6 +161,7 @@ export const PaneButton = Radium(function(props) { | |||
| className={divClassNames} | |||
| role="button" | |||
| tabIndex="0" | |||
| aria-label={props.ariaLabel} | |||
There was a problem hiding this comment.
I find it so annoying that React doesn't convert ariaLabel to aria-label! Sigh.
megcrenshaw
approved these changes
Dec 14, 2022
|
we had the same idea, whoever merges second will have some minor merge conflicts :) my PR |
maddiedierker
pushed a commit
that referenced
this pull request
Dec 16, 2022
This reverts commit a690533.
maddiedierker
pushed a commit
that referenced
this pull request
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A11Y-43
Since Weblab's open/close fullscreen preview button (it's actually a div with
role="button") is icon-only, it needs an aria-label attribute. I added anariaLabelprop to the PaneButton component for this use case.