Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add ariaLabel prop to PaneButton for icon-only buttons" #49573

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Revert "Add ariaLabel prop to PaneButton for icon-only buttons" #49573

merged 1 commit into from
Dec 16, 2022

Conversation

maddiedierker
Copy link
Contributor

Reverts #49529

@maddiedierker maddiedierker requested a review from a team as a code owner December 16, 2022 00:53
@maddiedierker maddiedierker merged commit b1d8a65 into staging Dec 16, 2022
@maddiedierker maddiedierker deleted the revert-49529-weblab-expand-button branch December 16, 2022 00:53
hannahbergam
hannahbergam reviewed Dec 16, 2022
View reviewed changes
Copy link
Contributor

@hannahbergam hannahbergam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Fwiw- I'd also be fine with a fix forward, if you wanted to keep the weblab portion of this but remove the duplicate PaneHeader stuff!

@maddiedierker
Copy link
Contributor Author

LGTM! Fwiw- I'd also be fine with a fix forward, if you wanted to keep the weblab portion of this but remove the duplicate PaneHeader stuff!

@hannahbergam yeah i'll open another PR with the actual change!

@maddiedierker maddiedierker mentioned this pull request Dec 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahbergam hannahbergam hannahbergam left review comments

@molly-moen molly-moen Awaiting requested review from molly-moen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maddiedierker @hannahbergam