-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DES-248][Phase 1.5 Rebranding] [Student Learning] Additional code workspace changes #50676
[DES-248][Phase 1.5 Rebranding] [Student Learning] Additional code workspace changes #50676
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine to me! In the screenshot however, it looks like the sample code is missing from the dialog/looks collapsed - is that intentional?
Not intentional, but the reason is only that I don't have access to generated code locally. Should work as before on integrated ends |
Updated PR description and screenshot to highlight the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the list of changes & the matching screenshots!
* phase1.5 - Dance party page added * Phase 1.5 - Hello world page updated * [Phase 1.5] Phase 1.5 Code Workspace Styles Update (#50095) * update codeWorkspace * update video modal * update code work space/instructions, buttons * update codeworkspace, instructions, etc * [Phase 1.5] Update codeworkSpace, Js Debugger icons, modals styling (#50233) * update codeworksSpace, Js Debugger icons styling * update codeWorkspace buttons styling on hover * update modals and modals buttons * * fix show code/block toggle button icon for redesign (#50621) * [Des-246][Phase 1.5][Student Learning] Share project modal updates (#50703) * share dialog * advanced share rebrand * share modal rebrand updates * [DES-248][Phase 1.5 Rebranding] [Student Learning] Additional code workspace changes (#50676) * show code modal update * update VersionHistory.jsx modal * update HintPrompt.jsx
[Phase 1.5 Rebranding] [Student Learning] Additional code workspace changes
Changes to look on screenshots:
Before:
After:
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: