Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DES-248][Phase 1.5 Rebranding] [Student Learning] Additional code workspace changes #50676

Conversation

levadadenys
Copy link
Collaborator

@levadadenys levadadenys commented Mar 9, 2023

[Phase 1.5 Rebranding] [Student Learning] Additional code workspace changes

Changes to look on screenshots:

  • yes/no buttons for instructions
  • the dialog - text&button colors

Before:
Знімок екрана 2023-03-10 о 19 48 31
Знімок екрана 2023-03-10 о 19 48 21

After:
Знімок екрана 2023-03-14 о 17 08 46
Знімок екрана 2023-03-14 о 17 07 44

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Copy link
Contributor

@sanchitmalhotra126 sanchitmalhotra126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine to me! In the screenshot however, it looks like the sample code is missing from the dialog/looks collapsed - is that intentional?

@levadadenys
Copy link
Collaborator Author

Code looks fine to me! In the screenshot however, it looks like the sample code is missing from the dialog/looks collapsed - is that intentional?

Not intentional, but the reason is only that I don't have access to generated code locally. Should work as before on integrated ends

@levadadenys levadadenys changed the title [Phase 1.5 Rebranding] [Student Learning] Additional code workspace changes [DES-248][Phase 1.5 Rebranding] [Student Learning] Additional code workspace changes Mar 13, 2023
@levadadenys
Copy link
Collaborator Author

Updated PR description and screenshot to highlight the changes

Copy link
Member

@breville breville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the list of changes & the matching screenshots!

@levadadenys levadadenys merged commit 46adf7a into denys/phase1.5/general Mar 14, 2023
@levadadenys levadadenys deleted the denys/phase1.5/des-248-additionalCodeWorkspace-changes branch March 14, 2023 16:08
levadadenys added a commit that referenced this pull request Mar 15, 2023
* phase1.5 - Dance party page added

* Phase 1.5 - Hello world page updated

* [Phase 1.5] Phase 1.5 Code Workspace Styles Update (#50095)

* update codeWorkspace

* update video modal

* update code work space/instructions, buttons

* update codeworkspace, instructions, etc

* [Phase 1.5] Update codeworkSpace, Js Debugger icons, modals styling (#50233)

* update codeworksSpace, Js Debugger icons styling

* update codeWorkspace buttons styling on hover

* update modals and modals buttons

* * fix show code/block toggle button icon for redesign (#50621)

* [Des-246][Phase 1.5][Student Learning] Share project modal updates (#50703)

* share dialog

* advanced share rebrand

* share modal rebrand updates

* [DES-248][Phase 1.5 Rebranding] [Student Learning]  Additional code workspace changes (#50676)

* show code modal update

*  update VersionHistory.jsx modal

* update HintPrompt.jsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants