Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Des-246][Phase 1.5][Student Learning] Share project modal updates #50703

Merged

Conversation

levadadenys
Copy link
Collaborator

[Des-246][Phase 1.5][Student Learning] Share project modal updates

Before:
Знімок екрана 2023-03-10 о 19 35 29
Знімок екрана 2023-03-10 о 19 35 33
Знімок екрана 2023-03-10 о 19 35 36
Знімок екрана 2023-03-10 о 19 35 39

After:
Знімок екрана 2023-03-10 о 19 26 14
Знімок екрана 2023-03-10 о 19 26 34
Знімок екрана 2023-03-10 о 19 26 39
Знімок екрана 2023-03-10 о 19 26 42

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@levadadenys levadadenys requested a review from a team March 10, 2023 17:36
@levadadenys levadadenys changed the base branch from staging to denys/phase1.5/general March 10, 2023 17:36
Copy link
Contributor

@molly-moen molly-moen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more style moves, otherwise looks good!

@levadadenys levadadenys merged commit 3375310 into denys/phase1.5/general Mar 14, 2023
@levadadenys levadadenys deleted the denys/phase1.5/des-246-shareProject-modal branch March 14, 2023 10:52
levadadenys added a commit that referenced this pull request Mar 15, 2023
* phase1.5 - Dance party page added

* Phase 1.5 - Hello world page updated

* [Phase 1.5] Phase 1.5 Code Workspace Styles Update (#50095)

* update codeWorkspace

* update video modal

* update code work space/instructions, buttons

* update codeworkspace, instructions, etc

* [Phase 1.5] Update codeworkSpace, Js Debugger icons, modals styling (#50233)

* update codeworksSpace, Js Debugger icons styling

* update codeWorkspace buttons styling on hover

* update modals and modals buttons

* * fix show code/block toggle button icon for redesign (#50621)

* [Des-246][Phase 1.5][Student Learning] Share project modal updates (#50703)

* share dialog

* advanced share rebrand

* share modal rebrand updates

* [DES-248][Phase 1.5 Rebranding] [Student Learning]  Additional code workspace changes (#50676)

* show code modal update

*  update VersionHistory.jsx modal

* update HintPrompt.jsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants