-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Des-246][Phase 1.5][Student Learning] Share project modal updates #50703
Merged
levadadenys
merged 6 commits into
denys/phase1.5/general
from
denys/phase1.5/des-246-shareProject-modal
Mar 14, 2023
Merged
[Des-246][Phase 1.5][Student Learning] Share project modal updates #50703
levadadenys
merged 6 commits into
denys/phase1.5/general
from
denys/phase1.5/des-246-shareProject-modal
Mar 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
molly-moen
reviewed
Mar 13, 2023
molly-moen
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple more style moves, otherwise looks good!
levadadenys
added a commit
that referenced
this pull request
Mar 15, 2023
* phase1.5 - Dance party page added * Phase 1.5 - Hello world page updated * [Phase 1.5] Phase 1.5 Code Workspace Styles Update (#50095) * update codeWorkspace * update video modal * update code work space/instructions, buttons * update codeworkspace, instructions, etc * [Phase 1.5] Update codeworkSpace, Js Debugger icons, modals styling (#50233) * update codeworksSpace, Js Debugger icons styling * update codeWorkspace buttons styling on hover * update modals and modals buttons * * fix show code/block toggle button icon for redesign (#50621) * [Des-246][Phase 1.5][Student Learning] Share project modal updates (#50703) * share dialog * advanced share rebrand * share modal rebrand updates * [DES-248][Phase 1.5 Rebranding] [Student Learning] Additional code workspace changes (#50676) * show code modal update * update VersionHistory.jsx modal * update HintPrompt.jsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Des-246][Phase 1.5][Student Learning] Share project modal updates
Before:
After:
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: