Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[Teach-298] Create section - Update dialog styling" #50707

Merged
merged 1 commit into from Mar 10, 2023
Merged

Revert "[Teach-298] Create section - Update dialog styling" #50707

merged 1 commit into from Mar 10, 2023

Conversation

bethanyaconnor
Copy link
Contributor

Reverts #50605

@bethanyaconnor bethanyaconnor merged commit 1ee76e5 into staging Mar 10, 2023
@bethanyaconnor bethanyaconnor deleted the revert-50605-denys/teach/teach-298 branch March 10, 2023 20:03
@bethanyaconnor
Copy link
Contributor Author

Diff that prompted the revert:

Screenshot 2023-03-10 at 11 48 47 AM

@rshipp
Copy link
Contributor

rshipp commented Mar 16, 2023 •
edited

adding more screenshots for context:

all from the progress tab (https://studio.code.org/teacher_dashboard/sections/<SECTION_ID>)

image
image
image
image

levadadenys added a commit that referenced this pull request Mar 19, 2023
@levadadenys
Revert "Revert "[Teach-298] Create section - Update dialog styling (#…
be23f8e 
…50605)" (#50707)"

This reverts commit 1ee76e5.
@levadadenys levadadenys mentioned this pull request Mar 19, 2023
Merged
8 tasks
levadadenys added a commit that referenced this pull request Mar 22, 2023
@levadadenys
[Teach-298] Create section - Update dialog styling [Rework/Fixed] (#5…
3482c75 
…0842)

* Revert "Revert "[Teach-298] Create section - Update dialog styling (#50605)" (#50707)"

This reverts commit 1ee76e5.

* add possibility to use rebranded heading3 if needed

* * fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levadadenys levadadenys Awaiting requested review from levadadenys

@rshipp rshipp Awaiting requested review from rshipp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bethanyaconnor @rshipp