Upgrade eslint-plugin-react

[molly-moen]

Upgrade to the latest version of eslint-plugin-react. We need to do this for our eslint upgrade, and it gives us additional linting benefits. Namely, prop types on functional components are now linted fully (it seems that nested objects were not being properly linted). This means we hit a few linter errors. I fixed a few that were in the student learning/vague ownership space. The rest seem to be teacher tools components, I've started a thread here on those.

The only other changes this enforced was adding rel="noreferrer" to links with target="_blank" (reasoning), and renaming a lifecycle method to the UNSAFE_ version.

Links

• jira ticket: SL-692

Testing story

Most of the changes here are adding ignores, and the other changes seem safe. I am relying on drone to validate this.

PR Checklist:

• Tests provide adequate coverage
• Privacy and Security impacts have been assessed
• Code is well-commented
• New features are translatable or updates will not break translations
• Relevant documentation has been added or updated
• User impact is well-understood and desirable
• Pull Request is labeled appropriately
• Follow-up work items (including potential tech debt) are tracked and linked

[bethanyaconnor]

What lint errors are you seeing for the components that need to be skipped? I spot checked a couple and they do have prop types (example 1, example 2). I know I've also seen linter errors when props aren't listed, I think for functional components, so I think I'm missing what's changed?

[molly-moen]

What lint errors are you seeing for the components that need to be skipped? I spot checked a couple and they do have prop types (example 1, example 2). I know I've also seen linter errors when props aren't listed, I think for functional components, so I think I'm missing what's changed?

@bethanyaconnor it's a bit subtle, I should have clarified. A lot of the issues are because a prop in a nested object isn't defined (so maybe my statement about not checking props in functional components was overly broad). In (example 1, programmingExpression.blockName is not part of programmingExpressionShape. Example 2 has the same problem, and also hasn't defined programmingExpression.name. There was at least one case of non-nested props not being defined (InstructorsOnly), so linting was at least being applied inconsistently.

[bethanyaconnor]

ahh makes sense thanks for clarifying!