TTS Autoplay bug fix #55713

juanmanzojr · 2024-01-11T17:36:01Z

Creates a Queue for Inline Audio such as instructions and hints to prevent Text to speech audio from playing all at once.

Links

jira ticket: here

Testing Story

Changes made to InlineAudioTest.js to include the AudioQueue context. All tests pass.

PR Checklist:

Tests provide adequate coverage
Privacy and Security impacts have been assessed
Code is well-commented
New features are translatable or updates will not break translations
Relevant documentation has been added or updated
User impact is well-understood and desirable
Pull Request is labeled appropriately
Follow-up work items (including potential tech debt) are tracked and linked

* boilerplate * updates for level creation * fix bug * add to allthethings * fix test * fix allthethings

- Schoology requires payload to be in the body, rather than a URL query. Canvas also accepts the payload in the body Signed-off-by: Nick Lathe <nick.lathe@code.org>

…1y/iframe-has-title Fix Violations of and Reenable `jsx-a11y/iframe-has-title`

* CSV for avon grove accounts to be purged * Change column name

DTT (Staging > Test) [robo-dtt]

* uitest: any student can complete rubric-enabled level * create teacher-associated students

[AccHack] Add labels for a few select and textarea components

…nd to page width (#55412)

… to non-standalone (#55450) * Prevent levelbuilders from accidentally switching a standalone course to non-standalone * Reword new unit creation flow * Fix tooltip * fix * Fix ui test

…ontent

[AccHack] add labels or aria-labels for a few more input fields

DTT (Staging > Test) [robo-dtt]

[AppLab] Fix PropTypes error in DataVisualizer

* Make code review code toggle tab navigable, need to confirm styling * Remove unnecessary classNames usage, rename module styles file * Fix icon size * Remove redundant button role, re-enable a11y interactive-supports-focus * Fix UI test

CanCanCan 3.5

Removing PWA experiment code

* add generic mutators to custom blocks * load invisible blocks onto hidden workspace

) * import translated messages based on user locale * missing word * use english for filipino * switch to dynamic import * use explicit extension

…_2024-01-05

DTS (Levelbuilder > Staging) [robo-dts]

* Revert "Revert "move regional partner search to dashboard"" * Use asset_path instead of webpack_asset_path

* Add string for select student option * Add student selection drop down component (redux connected) * Add student and section dropdown selectors to rubric content tab on FAB * Add section drop down and lesson name header to settings tab for rubric redesign * Remove commented out code * Move student selector style to rubric css styles * Remove redundant rubricId parameter * Fix test for new parameters * Remove debugging console logs * Update tests to connect them to the redux store and look for student/ section dropdowns

* Add user controller for show UI refresh * Use table-v2 * Add user controller logic * Fix values * Simplify * Remove last reference

* add tile images * update start-codeorg.haml * add aria labels to resources buttons * create resources_for_educators.haml view * update link on pl resource tile * add success page strings * update /afe/success.haml

* correctly translate behavior names * use both scopes * remove duplicate call

…uctions Adding LTI section login instructions

…sheet (#55591)

carl-codeorg

Had one question about the shared_consts and one suggestion for a new test. Overall I think the queue was a great idea. Nice thinking!

carl-codeorg · 2024-01-31T21:47:24Z

lib/cdo/shared_constants.rb

@@ -642,6 +642,33 @@ module SharedConstants
    }
  ).freeze

+  VOICES = {


I see there was a TODO where these constants originally were. Is there a reason why these are shared with Dashboard? If they're defined separately in Dashboard currently, then we should switch the references from wherever they are in Dashboard to shared_constants.

carl-codeorg · 2024-01-31T21:51:16Z

apps/test/unit/templates/instructions/InlineAudioTest.js

@@ -3,7 +3,8 @@ import {mount} from 'enzyme';
 import sinon from 'sinon';
 import {setExternalGlobals} from '../../../util/testUtils';
 import React from 'react';
-import {StatelessInlineAudio} from '@cdo/apps/templates/instructions/InlineAudio';
+import {UnconnectedInlineAudio as InlineAudio} from '@cdo/apps/templates/instructions/InlineAudio';
+import {AudioQueue} from '@cdo/apps/templates/instructions/AudioQueue';


Is there a way we could add a test where multiple audio items are input, and the test ensures they are played sequentially? Or maybe a test that ensures that the AudioQueue component functions properly?

molly-moen and others added 30 commits December 14, 2023 08:59

Set up python lab (try 2) (#55370)

0620662

* boilerplate * updates for level creation * fix bug * add to allthethings * fix test * fix allthethings

Change access token req payload (#55411)

ae6ffc7

- Schoology requires payload to be in the body, rather than a URL query. Canvas also accepts the payload in the body Signed-off-by: Nick Lathe <nick.lathe@code.org>

remove redundant aria label

d50f508

updating hoc_mode in test (#55447)

cf829db

Merge pull request #55442 from code-dot-org/acc-hack-23/linter/jsx-a1…

e716016

…1y/iframe-has-title Fix Violations of and Reenable `jsx-a11y/iframe-has-title`

CSV for avon grove accounts to be purged (#55395)

395e9c8

* CSV for avon grove accounts to be purged * Change column name

Merge pull request #55462 from code-dot-org/staging

e0b5641

DTT (Staging > Test) [robo-dtt]

uitest: any student can complete rubric-enabled level (#55396)

fb2cefe

* uitest: any student can complete rubric-enabled level * create teacher-associated students

Donor list update on code.org/about/supporters - Dec 2023 (#55460)

fca9da7

Allow no caption for dynamic Theater audio (#55373)

d1a7845

Merge pull request #55435 from code-dot-org/eb-a11y-add-aria-labels

89e7163

[AccHack] Add labels for a few select and textarea components

Make teacher dashboard pages full width, allow progress table to expa…

3de4fd4

…nd to page width (#55412)

add aria label to textarea on CertificateBatch

c47f0bd

add aria label for textarea on AddMultipleStudents component

e0aa0ed

add aria label for textarea on CreateStandardsReport component

81651d1

add htmlFor and id to zip code input on RegionalPartnerSearch

713850e

add aria label for textarea in levelbuilder ManifestEditor

f47475f

Prevent levelbuilders from accidentally switching a standalone course…

4777ce6

… to non-standalone (#55450) * Prevent levelbuilders from accidentally switching a standalone course to non-standalone * Reword new unit creation flow * Fix tooltip * fix * Fix ui test

Merge branch 'staging' into acc-hack-23/linter/jsx-a11y/heading-has-c…

af3c695

…ontent

Merge pull request #55465 from code-dot-org/eb-a11y-form-field-labels

c09aec5

[AccHack] add labels or aria-labels for a few more input fields

redirect events all back to map (#55467)

8bb4c37

Merge pull request #55472 from code-dot-org/staging

74c01f2

DTT (Staging > Test) [robo-dtt]

Merge pull request #55424 from code-dot-org/eb-csp-data-viz-debugging

55a56e9

[AppLab] Fix PropTypes error in DataVisualizer

Enable a11y/interactive-supports-focus (#55401)

ffa1bb3

* Make code review code toggle tab navigable, need to confirm styling * Remove unnecessary classNames usage, rename module styles file * Fix icon size * Remove redundant button role, re-enable a11y interactive-supports-focus * Fix UI test

Avon grove accounts csv split up into csvs of 500 users (#55475)

a113fa7

etags updates

cb3c91f

dashboard i18n updates - Arabic

06d8ae3

dashboard i18n updates - Azerbaijani

e3e94a2

dashboard i18n updates - Catalan

2038353

dashboard i18n updates - Czech

e172ab8

daynew and others added 22 commits January 4, 2024 16:12

Adding LTI section login instructions

b5511b0

Merge pull request #50710 from code-dot-org/cancancan-3.5

0bda958

CanCanCan 3.5

Merge pull request #55563 from code-dot-org/remove-pwa-experiment

fe2ef70

Removing PWA experiment code

[Google Blockly] Maintain support for invisible top blocks (#55520)

7ac5f62

* add generic mutators to custom blocks * load invisible blocks onto hidden workspace

[Google Blockly] import translated messages based on user locale (#55542

e197819

) * import translated messages based on user locale * missing word * use english for filipino * switch to dynamic import * use explicit extension

levelbuilder content changes (-robo-commit)

79895d6

staging content changes (-robo-commit)

2520e4d

Merge remote-tracking branch 'origin/levelbuilder' into dts_candidate…

c34151d

…_2024-01-05

Merge pull request #55586 from code-dot-org/dts_candidate_2024-01-05

5b1f7f0

DTS (Levelbuilder > Staging) [robo-dts]

Revert "Revert "move regional partner search to dashboard"" (#55517)

9a105d5

* Revert "Revert "move regional partner search to dashboard"" * Use asset_path instead of webpack_asset_path

Remove commit msg check from DTS command (#55579)

f83a341

[Progress] Adds a user setting to show progress table V2 (#55557)

e5125d0

* Add user controller for show UI refresh * Use table-v2 * Add user controller logic * Fix values * Simplify * Remove last reference

staging content changes (-)

9ed3891

Update code.org/afe/success (#55568)

815b83c

* add tile images * update start-codeorg.haml * add aria labels to resources buttons * create resources_for_educators.haml view * update link on pl resource tile * add success page strings * update /afe/success.haml

Translate behavior call and definition names the same way (#55576)

c7dbf69

* correctly translate behavior names * use both scopes * remove duplicate call

Merge pull request #55585 from code-dot-org/p20-601_lti-section-instr…

460a15a

…uctions Adding LTI section login instructions

Specify input[type="text"] styles on design-system-pegasus.scss style…

eb31820

…sheet (#55591)

Audio queue for tts

055c62a

Merge branch 'staging' into tts-autoplay-bug-fix

c15a257

TTS autoplay bug fix

4446955

Audio queue for TTS

d628672

juanmanzojr requested a review from a team January 11, 2024 17:36

juanmanzojr added 2 commits January 18, 2024 09:30

Remove Radium from InlineAudio to prevent conflict in contexts

c3c20d3

Include context in unit tests for InlineAudio

0b3fa76

carl-codeorg reviewed Jan 31, 2024

View reviewed changes

Unit tests for audio queue

af43b89

snickell closed this Feb 3, 2024

snickell force-pushed the staging branch from d185420 to 8c006de Compare February 3, 2024 05:29

juanmanzojr mentioned this pull request Feb 5, 2024

TTS Autoplay bug fix #56324

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TTS Autoplay bug fix #55713

TTS Autoplay bug fix #55713

juanmanzojr commented Jan 11, 2024 •

edited

carl-codeorg left a comment

carl-codeorg Jan 31, 2024

carl-codeorg Jan 31, 2024

TTS Autoplay bug fix #55713

TTS Autoplay bug fix #55713

Conversation

juanmanzojr commented Jan 11, 2024 • edited

Links

Testing Story

PR Checklist:

carl-codeorg left a comment

Choose a reason for hiding this comment

carl-codeorg Jan 31, 2024

Choose a reason for hiding this comment

carl-codeorg Jan 31, 2024

Choose a reason for hiding this comment

juanmanzojr commented Jan 11, 2024 •

edited