TTS Autoplay bug fix #56324
Merged
TTS Autoplay bug fix #56324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanmanzojr
force-pushed
the
tts-autoplay-bug-fix
branch
from
68eaf5e
to
802c256
Compare
juanmanzojr
force-pushed
the
tts-autoplay-bug-fix
branch
from
15a8e35
to
7cfa8e1
Compare
carl-codeorg
reviewed
Apr 8, 2024
| @@ -652,6 +652,33 @@ module SharedConstants | |||
| } | |||
| ).freeze | |||
|
|
|||
| VOICES = { | |||
There was a problem hiding this comment.
Resurrecting my old comment from the pre-LFS PR: Why are we putting these into shared_constants.rb if none of these constants are referenced in Rails?
There was a problem hiding this comment.
This was because we had duplicated the VOICES in both JavaScript and Ruby (in dashboard/app/models/concerns/text_to_speech.rb) and that's what SharedConstants are for.
What is missing is using the SharedConstants version of VOICES in the TextToSpeech concern and removing it from there.
There was a problem hiding this comment.
Oh ok, makes total sense. We should probably open a ticket to do that, otherwise we haven't really improved the situation by moving them into shared_constants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a Queue for InlineAudios such as instructions and hints to prevent Text to Speech audio from playing all at once when Text to Speech is enabled in a course.
Before Audio Queue
Untitled.mov
After Audio Queue implementation
Screen.Recording.2024-04-01.at.12.35.07.PM.mov
Clicking hint while hint Audio is playing pauses hint audio, Clicking hint while another audio is playing adds to queue
Screen.Recording.2024-04-01.at.12.30.50.PM.mov
Links
Testing Story
Changes made to
InlineAudioTest.jsto include theAudioQueuecontext. All tests pass.PR Checklist: