Add ability to delete a project from the featured_projects table #56532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanchitmalhotra126
approved these changes
Feb 13, 2024
| @@ -151,6 +151,17 @@ const feature = (channel, publishedAt) => { | |||
| .fail(handleFeatureFailure); | |||
| }; | |||
|
|
|||
| const onDelete = channel => { | |||
| var url = `/featured_projects/${channel}`; | |||
| $.ajax({ | |||
There was a problem hiding this comment.
nit: can we use fetch here? looks like we have other usages of $.ajax in this file though so also okay if you want to keep it consistent (and we can upgrade this file up later as a follow-up)
There was a problem hiding this comment.
Sure! I'll wait till #56555 is merged since the authenticity token was required when fetch was used.
| @@ -151,6 +151,17 @@ const feature = (channel, publishedAt) => { | |||
| .fail(handleFeatureFailure); | |||
| }; | |||
|
|
|||
| const onDelete = channel => { | |||
| var url = `/featured_projects/${channel}`; | |||
Good point! I asked @samantha-code about this and she said 'Remove' sounds good. Thanks! |
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows an admin user to delete a project from the
featured_projectstable displayed at 'projects/featured' (must have project validator permission to have access to this page). Currently there are 232 featured projects, and 550 projects in the ‘Archive of Previously Featured Projects’.Many of the projects are no longer available (project deleted) and some of them were added unintentionally. There are currently too many to be able to manage effectively for an admin user.
Note that deleting a project from the
featured_projectsdoes NOT delete the project itself, and it is possible to re-add it to thefeatured_projectstable.Updates include:
This is part 1 of 2 steps described here.
Screencast video AFTER update: Note that button now displays 'Remove' instead of 'Delete' based on this feedback.
delete-featured-project.mp4
Links
jira
Testing story
I tested locally, and I also checked the
featured_projectstable usingmysql-client-dashboard-readerto confirm the entry was removed from the table.Deployment strategy
Follow-up work
Follow-up work includes adding a confirmation modal when an admin users clicks on the 'Delete' button to delete a featured project. https://codedotorg.atlassian.net/browse/LABS-507Asked @samantha-code about this and she prefers no confirmation dialog for 'Delete/Remove' button.
Privacy
Security
Caching
PR Checklist: