Add delete request to HttpClient #56555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
sanchitmalhotra126
approved these changes
Feb 13, 2024
apps/src/util/HttpClient.ts
Outdated
| @@ -74,12 +74,13 @@ async function fetchJson<ResponseType>( | |||
| } | |||
|
|
|||
| /** | |||
| * POST to the given endpoint. Adds the Rails authenticity | |||
| * o to the given endpoint. Adds the Rails authenticity | |||
There was a problem hiding this comment.
nit: update comment - maybe "Sends a request to the given endpoint"?
There was a problem hiding this comment.
Oh yeah! Forgot to fix this - updated. Thanks!
There was a problem hiding this comment.
And thanks for pairing with me on this @sanchitmalhotra126 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a send DELETE request function to
HttpClient. I plan to use this new function in #56532. Other requests made inFeaturedProjectsTableuseajaxand when I attempted to usefetchinstead, I received a 422 (unprocessable entity) server error because the authenticity token was required. Thus, I wanted to use a request function fromHttpClientbut 'delete' was not yet available.Links
Testing story
I tested locally in conjunction with changes in #56532 checking both DELETE and PUT requests.
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: