Music: more UI testing #57850
Merged
Music: more UI testing #57850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanchitmalhotra126
approved these changes
Apr 8, 2024
|
|
||
| # There should still be a music timeline entry. | ||
| And element ".timeline-element" is visible | ||
|
|
||
| Examples: | ||
| | url | test_name | |
There was a problem hiding this comment.
Should we add a standalone project link here too? (not exactly sure how those work in UI tests, since presumably one would have to be created)
There was a problem hiding this comment.
Absolutely. This will also help test the launch2024 music library in addition to intro2024. I tried it out in this PR, but came across the issue that the Then I wait until I am on step doesn't work because of the dynamic URL.
Would love to figure this out in a small follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Music Lab UI test now does a little more: it opens the sound selection UI, chooses a pack, and chooses a sound.
Follow-up to #57783.