Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Music: more UI testing #57850

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Music: more UI testing #57850

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 16 additions & 1 deletion dashboard/test/ui/features/star_labs/musiclab/musiclab_drag_block.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,22 @@ Scenario Outline: Dragging play sound block
# There should now be a music timeline entry.
And element ".timeline-element" is visible

# Click the field inside the attached "play sound" block.
And I click block field "[data-id='when-run-block'] > [data-id='play_sound_at_current_location_simple2'] > .blocklyEditableText"

# Click on the second pack inside the sounds panel.
And I click selector "#sounds-panel .sounds-panel-folder-row:nth-of-type(2)"

# Click on the second sound inside the sounds panel.
And I click selector "#sounds-panel .sounds-panel-sound-row:nth-of-type(2)"

# The sounds panel should be dismissed.
And I wait until element "#sounds-panel" is not visible

# There should still be a music timeline entry.
And element ".timeline-element" is visible

Examples:
| url | test_name |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a standalone project link here too? (not exactly sure how those work in UI tests, since presumably one would have to be created)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely. This will also help test the launch2024 music library in addition to intro2024. I tried it out in this PR, but came across the issue that the Then I wait until I am on step doesn't work because of the dynamic URL.
Would love to figure this out in a small follow-up.

| http://studio.code.org/s/allthethings/lessons/46/levels/4 | music lab script level |
| http://studio.code.org/projectbeats?show-video=false | music lab incubator |
| http://studio.code.org/projectbeats | music lab incubator |