New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gen AI Lab: add bot icon and clear button to chat window #57879
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question re CopyButton, other than that LGTM!
Sorry, I thought CopyButton
is rendered as a child of Button
, must be me being not completely awaken 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
nit for the future: (Maybe we already have this in jira) Maybe update the CopyButton to use new DesignSystem Button (for better ui)?
@levadadenys added to Jira here: https://codedotorg.atlassian.net/browse/LABS-680 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just to double check are we / @markabarrett okay with the two different button styles (for copy and clear)?
@sanchitmalhotra126 oh the styling is definitely not perfect, I expect we'll continue to iterate/improve here (eg, the header background itself is black here, but gray in the mocks, so we'd ideally restyle the header and also change the color of the clear button as well). The copy button was actually not in the mocks, but Sam suggested we keep it around for the pilot since it already exists. |
Adds a bot icon from our design team to the chat window, as well as a clear button in the header.
After
Before