Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gen AI Lab: add bot icon and clear button to chat window #57879

Merged
merged 11 commits into from Apr 11, 2024

Conversation

bencodeorg
Copy link
Contributor

Adds a bot icon from our design team to the chat window, as well as a clear button in the header.

After

image

Before

image

@bencodeorg bencodeorg requested a review from a team April 8, 2024 22:31
Copy link
Collaborator

@levadadenys levadadenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question re CopyButton, other than that LGTM!
Sorry, I thought CopyButton is rendered as a child of Button, must be me being not completely awaken 😆

Copy link
Collaborator

@levadadenys levadadenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nit for the future: (Maybe we already have this in jira) Maybe update the CopyButton to use new DesignSystem Button (for better ui)?

@bencodeorg
Copy link
Contributor Author

@levadadenys added to Jira here: https://codedotorg.atlassian.net/browse/LABS-680

Copy link
Contributor

@fisher-alice fisher-alice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@sanchitmalhotra126 sanchitmalhotra126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just to double check are we / @markabarrett okay with the two different button styles (for copy and clear)?

@bencodeorg
Copy link
Contributor Author

bencodeorg commented Apr 9, 2024

Nice! Just to double check are we / @markabarrett okay with the two different button styles (for copy and clear)?

@sanchitmalhotra126 oh the styling is definitely not perfect, I expect we'll continue to iterate/improve here (eg, the header background itself is black here, but gray in the mocks, so we'd ideally restyle the header and also change the color of the clear button as well). The copy button was actually not in the mocks, but Sam suggested we keep it around for the pilot since it already exists.

@bencodeorg bencodeorg merged commit 5a897b7 into staging Apr 11, 2024
2 checks passed
@bencodeorg bencodeorg deleted the ben/gen-ai-add-bot-icon-messages branch April 11, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants