Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gen AI] Update Panel header and small UI updates #57996

Merged
merged 1 commit into from Apr 12, 2024

Conversation

fisher-alice
Copy link
Contributor

@fisher-alice fisher-alice commented Apr 12, 2024

This PR updates AichatView so that the copy/clear buttons are rendered in the chat workspace and not the presentation view. It also updates chat workspace so that it is scrollable and assigns keys to list items to avoid warnings in dev console.

Before:

Panel headers -
Screenshot 2024-04-12 at 2 33 08 PM

Screenshot 2024-04-12 at 2 32 59 PM

After:

Panel headers -
Screenshot 2024-04-12 at 2 35 37 PM

Screenshot 2024-04-12 at 2 34 36 PM

Chat workspace is scrollable:

scrollable.workspace.mp4

Links

Noticed on staging the unintended change from #57879.

Testing story

Tested locally on /allthethings.

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@fisher-alice fisher-alice marked this pull request as ready for review April 12, 2024 19:41
@fisher-alice fisher-alice merged commit d20edef into staging Apr 12, 2024
2 checks passed
@fisher-alice fisher-alice deleted the alice/ui-updates branch April 12, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants