Cleans up old sign up user type experiment #57905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TurnerRiley
approved these changes
Apr 9, 2024
apps/src/sites/studio/pages/devise/registrations/_finish_sign_up.js
Outdated
Show resolved
Hide resolved
bethanyaconnor
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sign up flow piloted a new user type button (see image below) a couple years ago. The DCDO flag was flipped to 'true' on production, but now we have an inconsistent user experience on test and locally (which are still defaulted to the old dropdown selection). Because the work I'm doing with School Association is safer with a comprehensive UI test, the test I wrote requires drone to assume the 'new' code that matches production (ie clicking on the teacher button instead of using the old dropdown). So, I'm cleaning it up!
The DCDO flag appears to be working through the logic within the experiments file that checks for a dcdo flag by the same name. I could not find any direct/other references to that flag.
Because this is a high traffic area, it would be great if reviewers could run the same search locally to ensure I'm not missing any surprise use cases!
Able to confirm that my local experience is the cards with this change:
Warning!!
The AP CSP Create Performance Task is in progress. The most critical dates are from April 3 - April 30, 2024. Please consider any risk introduced by this PR that could affect our students taking AP CSP. Code.org students taking AP CSP primarily use App Lab for their Create Task, however a small percent use Game Lab. Carefully consider whether your change has any risk of alterering, changing, or breaking anything in these two labs. Even small changes, such as a different button color, are considered significant during this time period. Reach out to the Student Learning team or Curriculum team for more details.
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: